lidavidm commented on a change in pull request #10960:
URL: https://github.com/apache/arrow/pull/10960#discussion_r711029548
##########
File path: cpp/src/arrow/compute/kernels/scalar_temporal.cc
##########
@@ -1103,6 +1399,115 @@ const FunctionDoc assume_timezone_doc{
{"timestamps"},
"AssumeTimezoneOptions"};
+const FunctionDoc years_between_doc{
+ "Compute the number of years between two timestamps",
+ ("Returns the number of year boundaries crossed from the first timestamp
to the\n"
Review comment:
I think it's fine, e.g. see
https://github.com/apache/arrow/blob/5260fd5970d34c62e0ae7680f606b29eab56d96b/cpp/src/arrow/compute/kernels/vector_nested.cc#L141
or
https://github.com/apache/arrow/blob/5260fd5970d34c62e0ae7680f606b29eab56d96b/cpp/src/arrow/compute/kernels/vector_sort.cc#L1643-L1650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
