nealrichardson commented on a change in pull request #11018:
URL: https://github.com/apache/arrow/pull/11018#discussion_r711118594
##########
File path: r/R/dplyr-summarize.R
##########
@@ -136,6 +136,17 @@ summarize_eval <- function(name, quosure, ctx, recurse =
FALSE) {
return()
}
+ if ("median" %in% funs_in_expr) {
+ expr <- wrap_median(expr)
Review comment:
My plan for this is to special case quantile and median in
`extract_aggregations`, and instead of inserting `expr <- as.symbol(tmpname)`,
i.e. just the temp variable name, we would insert
`str2lang(paste0("arrow_list_element(", tmpname, ", 0L)"))`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
