alamb commented on pull request #971:
URL: https://github.com/apache/arrow-datafusion/pull/971#issuecomment-922260622
unfortunately when I merged apache/master into this branch locally, several
tests failed. It looks like a few newly added tests also need to be updated
```
failures:
---- execution::context::tests::window_partition_by_order_by stdout ----
thread 'execution::context::tests::window_partition_by_order_by' panicked at
'assertion failed: `(left == right)`
left:
`["+----+----+--------------+-----------------------------------+----------------------------------+------------------------------------------+--------------+----------------+--------------+--------------+--------------+",
"| c1 | c2 | ROW_NUMBER() | FIRST_VALUE(test.c2 Plus test.c1) |
LAST_VALUE(test.c2 Plus test.c1) | NTH_VALUE(test.c2 Plus test.c1,Int64(1)) |
SUM(test.c2) | COUNT(test.c2) | MAX(test.c2) | MIN(test.c2) | AVG(test.c2) |",
"+----+----+--------------+-----------------------------------+----------------------------------+------------------------------------------+--------------+----------------+--------------+--------------+--------------+",
"| 0 | 1 | 1 | 1 | 1
| 1 | 1 | 1
| 1 | 1 | 1 |", "| 0 | 2 | 1
| 2 | 2
| 2
| 2 | 1 | 2
| 2 | 2 |", "| 0 | 3 | 1 | 3
| 3 | 3
| 3 | 1 | 3 | 3
| 3 |", "| 0 | 4 | 1 | 4
| 4 | 4
| 4 | 1 | 4 | 4 | 4
|", "| 0 | 5 | 1 | 5 | 5
| 5 | 5
| 1 | 5 | 5 | 5 |",
"+----+----+--------------+-----------------------------------+----------------------------------+------------------------------------------+--------------+----------------+--------------+--------------+-----------
---+"]`,
right:
`["+----+----+--------------+--------------------------------+-------------------------------+---------------------------------------+--------------+----------------+--------------+--------------+--------------+",
"| c1 | c2 | ROW_NUMBER() | FIRST_VALUE(test.c2 + test.c1) |
LAST_VALUE(test.c2 + test.c1) | NTH_VALUE(test.c2 + test.c1,Int64(1)) |
SUM(test.c2) | COUNT(test.c2) | MAX(test.c2) | MIN(test.c2) | AVG(test.c2) |",
"+----+----+--------------+--------------------------------+-------------------------------+---------------------------------------+--------------+----------------+--------------+--------------+--------------+",
"| 0 | 1 | 1 | 1 | 1
| 1 | 1 | 1
| 1 | 1 | 1 |", "| 0 | 2 | 1
| 2 | 2 | 2
| 2
| 1 | 2 | 2 | 2 |", "|
0 | 3 | 1 | 3 | 3
| 3 | 3 | 1
| 3 | 3 | 3 |", "| 0 | 4 | 1 | 4
| 4 | 4
| 4 | 1 | 4 | 4
| 4 |", "| 0 | 5 | 1 | 5
| 5 | 5 | 5
| 1 | 5 | 5 | 5 |",
"+----+----+--------------+--------------------------------+-------------------------------+---------------------------------------+--------------+----------------+--------------+--------------+--------------+"]`:
expected:
[
"+----+----+--------------+-----------------------------------+----------------------------------+------------------------------------------+--------------+----------------+--------------+--------------+--------------+",
"| c1 | c2 | ROW_NUMBER() | FIRST_VALUE(test.c2 Plus test.c1) |
LAST_VALUE(test.c2 Plus test.c1) | NTH_VALUE(test.c2 Plus test.c1,Int64(1)) |
SUM(test.c2) | COUNT(test.c2) | MAX(test.c2) | MIN(test.c2) | AVG(test.c2) |",
"+----+----+--------------+-----------------------------------+----------------------------------+------------------------------------------+--------------+----------------+--------------+--------------+--------------+",
"| 0 | 1 | 1 | 1 | 1
| 1 | 1
| 1 | 1 | 1 | 1 |",
"| 0 | 2 | 1 | 2 | 2
| 2 | 2
| 1 | 2 | 2 | 2 |",
"| 0 | 3 | 1 | 3 | 3
| 3 | 3
| 1 | 3 | 3 | 3 |",
"| 0 | 4 | 1 | 4 | 4
| 4 | 4
| 1 | 4 | 4 | 4 |",
"| 0 | 5 | 1 | 5 | 5
| 5 | 5
| 1 | 5 | 5 | 5 |",
"+----+----+--------------+-----------------------------------+----------------------------------+------------------------------------------+--------------+----------------+--------------+--------------+--------------+",
]
actual:
[
"+----+----+--------------+--------------------------------+-------------------------------+---------------------------------------+--------------+----------------+--------------+--------------+--------------+",
"| c1 | c2 | ROW_NUMBER() | FIRST_VALUE(test.c2 + test.c1) |
LAST_VALUE(test.c2 + test.c1) | NTH_VALUE(test.c2 + test.c1,Int64(1)) |
SUM(test.c2) | COUNT(test.c2) | MAX(test.c2) | MIN(test.c2) | AVG(test.c2) |",
"+----+----+--------------+--------------------------------+-------------------------------+---------------------------------------+--------------+----------------+--------------+--------------+--------------+",
"| 0 | 1 | 1 | 1 | 1
| 1 | 1 | 1
| 1 | 1 | 1 |",
"| 0 | 2 | 1 | 2 | 2
| 2 | 2 | 1
| 2 | 2 | 2 |",
"| 0 | 3 | 1 | 3 | 3
| 3 | 3 | 1
| 3 | 3 | 3 |",
"| 0 | 4 | 1 | 4 | 4
| 4 | 4 | 1
| 4 | 4 | 4 |",
"| 0 | 5 | 1 | 5 | 5
| 5 | 5 | 1
| 5 | 5 | 5 |",
"+----+----+--------------+--------------------------------+-------------------------------+---------------------------------------+--------------+----------------+--------------+--------------+--------------+",
]
', datafusion/src/execution/context.rs:1688:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
---- optimizer::common_subexpr_eliminate::test::subexpr_in_different_order
stdout ----
thread
'optimizer::common_subexpr_eliminate::test::subexpr_in_different_order'
panicked at 'assertion failed: `(left == right)`
left: `"Projection: Int32(1) + #test.a, #test.a + Int32(1)\n TableScan:
test projection=None"`,
right: `"Projection: Int32(1) Plus #test.a, #test.a Plus Int32(1)\n
TableScan: test projection=None"`',
datafusion/src/optimizer/common_subexpr_eliminate.rs:647:9
---- optimizer::common_subexpr_eliminate::test::cross_plans_subexpr stdout
----
thread 'optimizer::common_subexpr_eliminate::test::cross_plans_subexpr'
panicked at 'assertion failed: `(left == right)`
left: `"Projection: #Int32(1) + test.a\n Projection: Int32(1) + #test.a\n
TableScan: test projection=None"`,
right: `"Projection: #Int32(1) Plus test.a\n Projection: Int32(1) Plus
#test.a\n TableScan: test projection=None"`',
datafusion/src/optimizer/common_subexpr_eliminate.rs:647:9
---- optimizer::common_subexpr_eliminate::test::subexpr_in_same_order stdout
----
thread 'optimizer::common_subexpr_eliminate::test::subexpr_in_same_order'
panicked at 'assertion failed: `(left == right)`
left: `"Projection: #BinaryExpr-+Column-test.aLiteral1 AS Int32(1) +
test.a AS first, #BinaryExpr-+Column-test.aLiteral1 AS Int32(1) + test.a AS
second\n Projection: Int32(1) + #test.a AS BinaryExpr-+Column-test.aLiteral1,
#test.a, #test.b, #test.c\n TableScan: test projection=None"`,
right: `"Projection: #BinaryExpr-+Column-test.aLiteral1 AS Int32(1) Plus
test.a AS first, #BinaryExpr-+Column-test.aLiteral1 AS Int32(1) Plus test.a AS
second\n Projection: Int32(1) Plus #test.a AS
BinaryExpr-+Column-test.aLiteral1, #test.a, #test.b, #test.c\n TableScan:
test projection=None"`',
datafusion/src/optimizer/common_subexpr_eliminate.rs:647:9
---- optimizer::common_subexpr_eliminate::test::aggregate stdout ----
thread 'optimizer::common_subexpr_eliminate::test::aggregate' panicked at
'assertion failed: `(left == right)`
left: `"Aggregate: groupBy=[[]], aggr=[[Int32(1) +
#AggregateFunction-AVGfalseColumn-test.a AS AVG(test.a), Int32(1) -
#AggregateFunction-AVGfalseColumn-test.a AS AVG(test.a)]]\n Projection:
AVG(#test.a) AS AggregateFunction-AVGfalseColumn-test.a, #test.a, #test.b,
#test.c\n TableScan: test projection=None"`,
right: `"Aggregate: groupBy=[[]], aggr=[[Int32(1) Plus
#AggregateFunction-AVGfalseColumn-test.a AS AVG(test.a), Int32(1) Minus
#AggregateFunction-AVGfalseColumn-test.a AS AVG(test.a)]]\n Projection:
AVG(#test.a) AS AggregateFunction-AVGfalseColumn-test.a, #test.a, #test.b,
#test.c\n TableScan: test projection=None"`',
datafusion/src/optimizer/common_subexpr_eliminate.rs:647:9
---- optimizer::common_subexpr_eliminate::test::tpch_q1_simplified stdout
----
thread 'optimizer::common_subexpr_eliminate::test::tpch_q1_simplified'
panicked at 'assertion failed: `(left == right)`
left: `"Aggregate: groupBy=[[]],
aggr=[[SUM(#BinaryExpr-*BinaryExpr--Column-test.bLiteral1Column-test.a AS
test.a * Int32(1) - test.b),
SUM(#BinaryExpr-*BinaryExpr--Column-test.bLiteral1Column-test.a AS test.a *
Int32(1) - test.b * Int32(1) + #test.c)]]\n Projection: #test.a * Int32(1) -
#test.b AS BinaryExpr-*BinaryExpr--Column-test.bLiteral1Column-test.a, #test.a,
#test.b, #test.c\n TableScan: test projection=None"`,
right: `"Aggregate: groupBy=[[]],
aggr=[[SUM(#BinaryExpr-*BinaryExpr--Column-test.bLiteral1Column-test.a AS
test.a Multiply Int32(1) Minus test.b),
SUM(#BinaryExpr-*BinaryExpr--Column-test.bLiteral1Column-test.a AS test.a
Multiply Int32(1) Minus test.b Multiply Int32(1) Plus #test.c)]]\n Projection:
#test.a Multiply Int32(1) Minus #test.b AS
BinaryExpr-*BinaryExpr--Column-test.bLiteral1Column-test.a, #test.a, #test.b,
#test.c\n TableScan: test projection=None"`',
datafusion/src/optimizer/common_subexpr_eliminate.rs:647:9
failures:
execution::context::tests::window_partition_by_order_by
optimizer::common_subexpr_eliminate::test::aggregate
optimizer::common_subexpr_eliminate::test::cross_plans_subexpr
optimizer::common_subexpr_eliminate::test::subexpr_in_different_order
optimizer::common_subexpr_eliminate::test::subexpr_in_same_order
optimizer::common_subexpr_eliminate::test::tpch_q1_simplified
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
