thisisnic commented on a change in pull request #11143: URL: https://github.com/apache/arrow/pull/11143#discussion_r711600408
########## File path: r/R/dplyr-distinct.R ########## @@ -0,0 +1,63 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# The following S3 methods are registered on load if dplyr is present + +distinct.arrow_dplyr_query <- function(.data, ..., .keep_all = FALSE) { + if (.keep_all == TRUE) { + # After ARROW-13993 is merged, we can implement this + arrow_not_supported("`distinct()` with `.keep_all = TRUE`") + } + + distinct_groups <- ensure_named_exprs(quos(...)) Review comment: This was annoying me, so I tried it again today. I got 90% of the way there, but I think ultimately, it requires us to effectively undo and redo any `group_by()` which happens before the call to `distinct()` I ended up with this monstrosity at the start of the code: ``` gv <- dplyr::group_vars(.data) gv_as_quo <- quos(!!!map(.data$selected_columns[gv], ~sym(.x$ToString()))) ``` This isn't correct though, as it's pulling out the Expression and not the R expression used to create it, which I guess we can't get back at this point? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
