kou commented on a change in pull request #11167:
URL: https://github.com/apache/arrow/pull/11167#discussion_r711658146
##########
File path: ruby/red-arrow/lib/arrow/table.rb
##########
@@ -287,6 +318,8 @@ def slice(*args)
filter_options.null_selection_behavior = :emit_null
sliced_tables = []
slicers.each do |slicer|
+ filter_options.null_selection_behavior = :drop if slicer ==
Arrow::Slicer::GreaterEqualCondition
+
Review comment:
Could you revert this for now?
This breaks existing tests.
How about working on this in another pull request?
BTW, `slicer == Arrow::Slicer::GreaterEqualCondition` is never true because
`slicer` is a condition object not condition class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
