amol- commented on pull request #11173: URL: https://github.com/apache/arrow/pull/11173#issuecomment-922747566
> I didn't know for Tanya Schlusser :-( > > As for the `dev/benchmark` directory, obviously noone has been working on it for years, and we have our own benchmarking solution now. So it would only be useful for historical purposes. If this was already a page in the Sphinx docs it would be easy to move it around and still keep it visible, but as a directory lying around in a random place it doesn't strike me as terribly useful. @nealrichardson @amol- What do you think? Not that I have much context in detail, but in general I think that the repository should reflect how things currently work and any code/docs that doesn't apply to current state of the system is distracting or misleading for people having to understand the codebase. Keeping historical knowledge is usually the purpose of the versioning system, so maybe we can delete the directory and add to the current benchmarking code (in a README or similar) a note that is based on the old code with a link to the revision that provides the old code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
