pitrou commented on a change in pull request #11026:
URL: https://github.com/apache/arrow/pull/11026#discussion_r712152943
##########
File path: python/pyarrow/_compute.pyx
##########
@@ -1091,6 +1091,22 @@ class AssumeTimezoneOptions(_AssumeTimezoneOptions):
self._set_options(timezone, ambiguous, nonexistent)
+cdef class _WeekOptions(FunctionOptions):
+ def _set_options(self, week_starts_monday, count_from_zero,
+ first_week_is_fully_in_year):
+ self.wrapped.reset(
+ new CWeekOptions(week_starts_monday, count_from_zero,
+ first_week_is_fully_in_year)
+ )
+
+
+class WeekOptions(_WeekOptions):
+ def __init__(self, week_starts_monday=True, count_from_zero=False,
Review comment:
These should be keyword-only arguments, as `WeekOptions(False, False,
True)` is basically write-only code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
