thisisnic commented on a change in pull request #11175:
URL: https://github.com/apache/arrow/pull/11175#discussion_r712227651
##########
File path: r/tests/testthat/test-dplyr-group-by.R
##########
@@ -62,9 +62,9 @@ test_that("ungroup", {
select(int, chr) %>%
ungroup() %>%
filter(int > 5) %>%
+ collect() %>%
summarize(min_int = min(int)),
Review comment:
Yeah, sorry, that was a bit vague! I'm assuming here that `summarize()`
is being called at the end of here to make sure that the `group_by()` has
happened successfully - currently `expect_dplyr_equal()` uses
`expect_equivalent()` and so ungrouped and grouped tibbles "look" the same to
it.
In that PR I mention, `expect_dplyr_equal()` has been updated to use
`expect_equal()` which will check for attributes, and so comparing a grouped
and ungrouped tibble will result in a test failure, meaning that the
`summarize()` here is no longer needed (if the only purpose for it is checking
that `group_by()` has worked).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
