jonkeane commented on pull request #11163:
URL: https://github.com/apache/arrow/pull/11163#issuecomment-923179999


   We should confirm this with @kszucs to make sure, but in my understanding 
they will be masked (and they are limited to the lifetime of the job anyway, 
though I only learned that by reading 
https://docs.github.com/en/actions/reference/authentication-in-a-workflow again 
just now!).
   
   We already have at least one example of [using something like 
this](https://github.com/apache/arrow/blob/master/dev/tasks/python-wheels/github.osx.arm64.yml#L155)
 which [obfuscates it 
appropriately](https://github.com/ursacomputing/crossbow/runs/3648587031#step:11:31).
   
   We could consider removing `printenv` (notably in 
[`ci/scripts/r_test.sh`](https://github.com/apache/arrow/blob/556c14c7a520163aa6dbfe351ba22207c7ce74a9/ci/scripts/r_test.sh#L27)
 ) but also [in two more places as 
well](https://github.com/apache/arrow/search?q=printenv) to be extra extra 
careful. (Maybe replace that with a macro that lists a few of the vars we end 
up caring about like `ARROW_R_DEV`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to