NGA-TRAN commented on a change in pull request #1030:
URL: https://github.com/apache/arrow-datafusion/pull/1030#discussion_r712458055
##########
File path: datafusion/src/logical_plan/mod.rs
##########
@@ -39,13 +39,14 @@ pub use expr::{
abs, acos, and, array, ascii, asin, atan, avg, binary_expr, bit_length,
btrim, case,
ceil, character_length, chr, col, columnize_expr, combine_filters, concat,
concat_ws,
cos, count, count_distinct, create_udaf, create_udf, date_part,
date_trunc, exp,
- exprlist_to_fields, floor, in_list, initcap, left, length, lit, ln, log10,
log2,
- lower, lpad, ltrim, max, md5, min, normalize_col, normalize_cols, now,
octet_length,
- or, random, regexp_match, regexp_replace, repeat, replace, replace_col,
reverse,
- right, round, rpad, rtrim, sha224, sha256, sha384, sha512, signum, sin,
split_part,
- sqrt, starts_with, strpos, substr, sum, tan, to_hex, translate, trim,
trunc,
- unnormalize_col, unnormalize_cols, upper, when, Column, Expr, ExprRewriter,
- ExpressionVisitor, Literal, Recursion, RewriteRecursion,
+ exprlist_to_fields, floor, in_list, initcap, left, length, lit,
+ lit_timestamp_nanosecond, ln, log10, log2, lower, lpad, ltrim, max, md5,
min,
Review comment:
`lit_timestamp_nanosecond` is newly added
##########
File path: datafusion/src/logical_plan/expr.rs
##########
@@ -1871,6 +1920,21 @@ mod tests {
assert!(maybe_expr.is_err());
}
+ #[test]
Review comment:
Here are a few examples: is `time` column has timestamp data type,
value 10 needs to also be a timestamp (in nanosecond in this case) to have the
expression analysis works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
