lidavidm commented on a change in pull request #11115:
URL: https://github.com/apache/arrow/pull/11115#discussion_r713871305
##########
File path: cpp/src/arrow/compute/kernels/codegen_internal.h
##########
@@ -270,6 +275,24 @@ struct OutputArrayWriter<Type,
enable_if_c_number_or_decimal<Type>> {
}
};
+template <typename Type>
+struct OutputArrayWriter<Type, enable_if_struct<Type>> {
Review comment:
Hmm, I'm frankly not sure that any of this works. A Struct array isn't
an array of Struct scalars, it's a nested array with one child for each struct
field. For instance, there isn't a buffer 1 in a struct array at all, only a
validity bitmap. This might still be made to work but it would have a lot of
indirections around wrapping/unwrapping scalars. It might be better to
specialize DivMod or consider a separate pattern for struct-returning
arithmetic functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
