projjal commented on a change in pull request #11193:
URL: https://github.com/apache/arrow/pull/11193#discussion_r713939964
##########
File path: cpp/src/gandiva/tests/projector_test.cc
##########
@@ -196,21 +202,23 @@ TEST_F(TestProjector, TestProjectCacheDecimalCast) {
auto expr0 = TreeExprBuilder::MakeExpression("castDECIMAL", {field_float64},
res_31_13);
std::shared_ptr<Projector> projector0;
ASSERT_OK(Projector::Make(schema, {expr0}, TestConfiguration(),
&projector0));
+ EXPECT_FALSE(projector0->GetBuiltFromCache());
// if the output scale is different, the cache can't be used.
auto res_31_14 = field("result", arrow::decimal(31, 14));
auto expr1 = TreeExprBuilder::MakeExpression("castDECIMAL", {field_float64},
res_31_14);
std::shared_ptr<Projector> projector1;
ASSERT_OK(Projector::Make(schema, {expr1}, TestConfiguration(),
&projector1));
- EXPECT_NE(projector0.get(), projector1.get());
+ // EXPECT_NE(projector0.get(), projector1.get()); -> old expect.
Review comment:
can remove the commented code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
