pitrou commented on a change in pull request #11211:
URL: https://github.com/apache/arrow/pull/11211#discussion_r714099237
##########
File path: appveyor.yml
##########
@@ -55,9 +55,6 @@ environment:
matrix:
# NOTE: clcache seems to work best with Ninja and worst with msbuild
# (as generated by cmake)
- - JOB: "Build"
- GENERATOR: Ninja
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
Review comment:
Can we keep this one but switch to a newer VS? It also differs by not
using conda packages for dependencies.
##########
File path: cpp/src/arrow/compute/exec/sink_node.cc
##########
@@ -64,22 +64,7 @@ class SinkNode : public ExecNode {
AsyncGenerator<util::optional<ExecBatch>>* out_gen) {
PushGenerator<util::optional<ExecBatch>> push_gen;
auto out = push_gen.producer();
- *out_gen = [push_gen] {
- // Awful workaround for MSVC 19.0 (Visual Studio 2015) bug.
- // For some types including Future<optional<ExecBatch>>,
- // std::is_convertible<T, T>::value will be false causing
- // SFINAE exclusion of the std::function constructor we need.
- // Definining a convertible (but distinct) type soothes the
- // faulty trait.
- struct ConvertibleToFuture {
- operator Future<util::optional<ExecBatch>>() && { // NOLINT
runtime/explicit
- return std::move(ret);
- }
- Future<util::optional<ExecBatch>> ret;
- };
-
- return ConvertibleToFuture{push_gen()};
- };
+ *out_gen = std::move(push_gen);
Review comment:
Ah, nice.
##########
File path: ci/appveyor-cpp-setup.bat
##########
@@ -83,12 +83,11 @@ if "%JOB%" NEQ "Build_Debug" (
@rem
if "%GENERATOR%"=="Ninja" set need_vcvarsall=1
if defined need_vcvarsall (
- @rem Select desired compiler version
- if "%APPVEYOR_BUILD_WORKER_IMAGE%" == "Visual Studio 2017" (
- call "C:\Program Files (x86)\Microsoft Visual
Studio\2017\Community\VC\Auxiliary\Build\vcvarsall.bat" amd64
- ) else (
- call "C:\Program Files (x86)\Microsoft Visual Studio
14.0\VC\vcvarsall.bat" amd64
+ if "%APPVEYOR_BUILD_WORKER_IMAGE%" != "Visual Studio 2017" (
+ @rem ARROW-14070 Visual Studio 2015 no longer supported
+ exit /B
Review comment:
Is this useful?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
