bjchambers commented on pull request #521: URL: https://github.com/apache/arrow-rs/pull/521#issuecomment-925291372
FWIW, I also believe there are bugs in the existing implementation in some cases of offsets. For instance, I think `bit_slice(0, len)` doesn't do anything to incorporate the `len` in the result, and then using `bit_and` on it later causes exceptions because the lengths don't line up. So, totally happy for their to be alternative / less buggy approaches. It may even be worth a proptest for this to make sure it handles all the cases? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
