lidavidm commented on pull request #11212: URL: https://github.com/apache/arrow/pull/11212#issuecomment-925334955
Even if we don't plan on extending the enum, personally I find something like `NullPlacement::NullsFirst` more readable than `/*nulls_last=*/false`. Especially since it's consistent with `SortOrder::Ascending/Descending` which you could otherwise argue is a boolean (but is more readable as an enum). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
