projjal commented on a change in pull request #11193:
URL: https://github.com/apache/arrow/pull/11193#discussion_r714708734



##########
File path: cpp/src/gandiva/projector.h
##########
@@ -34,6 +34,34 @@ namespace gandiva {
 
 class LLVMGenerator;
 
+class ProjectorCacheKey {

Review comment:
       ProjectorCacheKey and FilterCacheKey are not really required now since 
we are now using a single cache and you are anyway creating basecachekey from 
them. Just create a single class named ExpressionCacheKey




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to