rok commented on a change in pull request #11026:
URL: https://github.com/apache/arrow/pull/11026#discussion_r714863602
##########
File path: r/src/compute.cpp
##########
@@ -318,14 +318,42 @@ std::shared_ptr<arrow::compute::FunctionOptions>
make_compute_options(
if (func_name == "day_of_week") {
using Options = arrow::compute::DayOfWeekOptions;
- bool one_based_numbering = true;
- if (!Rf_isNull(options["one_based_numbering"])) {
- one_based_numbering =
cpp11::as_cpp<bool>(options["one_based_numbering"]);
+ bool count_from_zero = false;
+ if (!Rf_isNull(options["count_from_zero"])) {
+ count_from_zero = cpp11::as_cpp<bool>(options["count_from_zero"]);
}
- return std::make_shared<Options>(one_based_numbering,
+ return std::make_shared<Options>(count_from_zero,
cpp11::as_cpp<uint32_t>(options["week_start"]));
}
+ if (func_name == "iso_week") {
+ using Options = arrow::compute::WeekOptions;
+ return std::make_shared<Options>(true, false, false);
Review comment:
Switched to `::ISODefaults()` so no longer necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
