rdettai commented on pull request #1010: URL: https://github.com/apache/arrow-datafusion/pull/1010#issuecomment-926014564
> I may get this wrong if you are not implying it's possible that a table can have its data in different file formats in the original doc I was not implying anything! 😄 I just didn't have an example in mind. Thanks for the pointers! I think that handling these cases will require creating dedicated `ExecutionPlan`s and do some further refactoring of the execution plan to allow re-utilization of the file format specific code. > But I what really want to argue is: why should we use diff manually and leave git diff away? I do know that git history is very important, I am not arguing that 😃. Do we all agree that we should directly replace the old implementations in this PR, even if it means that we will need to modify a large part of the code base at once? Does someone have a better split for this PR in mind? PS: just opened a new [branch](https://github.com/rdettai/arrow-datafusion/tree/refacto-providers-store) with the addition of the `ObjectStore`. I will pull it into this one once (and if) I am satisfied with the result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
