nealrichardson commented on pull request #11208: URL: https://github.com/apache/arrow/pull/11208#issuecomment-926575174
> This looks great. I've made two small comments. I presume the windows failures (it looks like all with timezone issues?) were there already we were ignoring (all) attributes before (it doesn't look like `check.tzone` gets passed through waldo) `check.tzone` is an argument to `all.equal()`, which waldo replaces. We need to instead pass `ignore_attr = "tzone"`, which I did in the places that failed for me locally. Need to inspect the windows failures (now that they finally did not time out) to see why they need this added now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
