emkornfield commented on a change in pull request #10652:
URL: https://github.com/apache/arrow/pull/10652#discussion_r716134684
##########
File path:
java/dataset/src/main/java/org/apache/arrow/dataset/scanner/ScanOptions.java
##########
@@ -26,12 +26,16 @@
/**
* Constructor.
- * @param columns Projected columns. Empty for scanning all columns.
* @param batchSize Maximum row number of each returned {@link
org.apache.arrow.vector.ipc.message.ArrowRecordBatch}
+ * @param columns Projected columns. Null for scanning all columns.
*/
- public ScanOptions(String[] columns, long batchSize) {
- this.columns = columns;
+ public ScanOptions(long batchSize, String[] columns) {
Review comment:
instead of allowing for null would it make sense to use Optional? I
agree with the concern of changing the API. It seems like using Optional would
also allow you keep this API for backwards compatibility purposes (even though
it is experimental it seems like this has limited cost).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
