Dandandan commented on a change in pull request #1055:
URL: https://github.com/apache/arrow-datafusion/pull/1055#discussion_r716245163



##########
File path: datafusion/src/physical_plan/hash_join.rs
##########
@@ -781,7 +782,7 @@ fn equal_rows(
             DataType::Float32 => equal_rows_elem!(Float32Array, l, r, left, 
right),
             DataType::Float64 => equal_rows_elem!(Float64Array, l, r, left, 
right),
             DataType::Timestamp(_, None) => {
-                equal_rows_elem!(Int64Array, l, r, left, right)
+                equal_rows_elem!(TimestampNanosecondArray, l, r, left, right)

Review comment:
       I think we also have to match on nanosecond unit in this case here (and 
on other units as well)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to