pitrou commented on a change in pull request #11237:
URL: https://github.com/apache/arrow/pull/11237#discussion_r716543092
##########
File path: docs/source/cpp/compute.rst
##########
@@ -1498,15 +1483,19 @@ in the respective option classes.
Structural transforms
~~~~~~~~~~~~~~~~~~~~~
-+--------------------------+------------+------------------------------------+---------------------+---------+
-| Function name | Arity | Input types |
Output type | Notes |
-+==========================+============+====================================+=====================+=========+
-| list_element | Binary | List-like (Arg 0), Integral (Arg 1)|
List value type | \(1) |
-+--------------------------+------------+------------------------------------+---------------------+---------+
-| list_flatten | Unary | List-like |
List value type | \(2) |
-+--------------------------+------------+------------------------------------+---------------------+---------+
-| list_parent_indices | Unary | List-like |
Int32 or Int64 | \(3) |
-+--------------------------+------------+------------------------------------+---------------------+---------+
++---------------------+------------+-------------------------------------+------------------+------------------------------+--------+
+| Function name | Arity | Input types |
Output type | Options class | Notes |
++=====================+============+=====================================+==================+==============================+========+
+| list_element | Binary | List-like (Arg 0), Integral (Arg 1) |
List value type | | \(1) |
++---------------------+------------+-------------------------------------+------------------+------------------------------+--------+
+| list_flatten | Unary | List-like |
List value type | | \(2) |
++---------------------+------------+-------------------------------------+------------------+------------------------------+--------+
+| list_parent_indices | Unary | List-like |
Int32 or Int64 | | \(3) |
++---------------------+------------+-------------------------------------+------------------+------------------------------+--------+
+| list_value_length | Unary | List-like |
Int32 or Int64 | | \(4) |
++---------------------+------------+-------------------------------------+------------------+------------------------------+--------+
+| make_struct | Varargs | Any |
Struct | :struct:`MakeStructOptions` | \(5) |
++---------------------+------------+-------------------------------------+------------------+------------------------------+--------+
Review comment:
"list_value_length" and "make_struct" are scalar functions, but this is
moving them to the category of vector functions. I don't think this is ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
