pitrou commented on a change in pull request #10973:
URL: https://github.com/apache/arrow/pull/10973#discussion_r716714655
##########
File path: dev/archery/archery/cli.py
##########
@@ -692,6 +692,8 @@ def _set_default(opt, default):
help="Seed for PRNG when generating test data")
@click.option('--with-cpp', type=bool, default=False,
help='Include C++ in integration tests')
[email protected]('--with-csharp', type=bool, default=False,
+ help='Include CSharp in integration tests')
Review comment:
Should it be spelled "C#" in this message?
##########
File path: dev/archery/archery/integration/datagen.py
##########
@@ -1557,82 +1557,102 @@ def _temp_path():
generate_primitive_case([0, 0, 0], name='primitive_zerolength'),
generate_primitive_large_offsets_case([17, 20])
+ .skip_category('csharp')
.skip_category('Go')
.skip_category('JS'),
generate_null_case([10, 0])
+ .skip_category('csharp')
+ .skip_category('Go') # TODO(ARROW-7901)
.skip_category('Go') # TODO(ARROW-7901)
.skip_category('JS'), # TODO(ARROW-7900)
generate_null_trivial_case([0, 0])
+ .skip_category('csharp')
.skip_category('Go') # TODO(ARROW-7901)
.skip_category('JS'), # TODO(ARROW-7900)
generate_decimal128_case()
.skip_category('Rust'),
generate_decimal256_case()
+ .skip_category('csharp')
Review comment:
According to
https://github.com/apache/arrow/blob/master/docs/source/status.rst#data-types,
Decimal256 should be supported?
##########
File path: dev/archery/archery/integration/tester_csharp.py
##########
@@ -0,0 +1,65 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import os
+
+from .tester import Tester
+from .util import run_cmd, ARROW_ROOT_DEFAULT, log
+
+
+class CSharpTester(Tester):
+ PRODUCER = True
+ CONSUMER = True
+
+ EXE_PATH = os.path.join(
+ ARROW_ROOT_DEFAULT,
'csharp/artifacts/Apache.Arrow.IntegrationTest/Debug/netcoreapp3.1/Apache.Arrow.IntegrationTest')
+
+ name = 'csharp'
Review comment:
Wouldn't "C#" be a better name for display?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
