lidavidm commented on a change in pull request #10933: URL: https://github.com/apache/arrow/pull/10933#discussion_r716741427
########## File path: cpp/src/arrow/compute/kernels/temporal_internal.h ########## @@ -0,0 +1,214 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <chrono> +#include <cstdint> + +#include "arrow/vendored/datetime.h" + +namespace arrow { + +namespace compute { +namespace internal { + +using arrow_vendored::date::days; +using arrow_vendored::date::floor; +using arrow_vendored::date::local_days; +using arrow_vendored::date::local_time; +using arrow_vendored::date::locate_zone; +using arrow_vendored::date::sys_days; +using arrow_vendored::date::sys_time; +using arrow_vendored::date::time_zone; +using arrow_vendored::date::year_month_day; + +static inline Result<const time_zone*> LocateZone(const std::string& timezone) { + try { + return locate_zone(timezone); + } catch (const std::runtime_error& ex) { + return Status::Invalid("Cannot locate timezone '", timezone, "': ", ex.what()); + } +} + +static inline const std::string& GetInputTimezone(const DataType& type) { + return checked_cast<const TimestampType&>(type).timezone(); +} + +static inline const std::string& GetInputTimezone(const Datum& datum) { + return checked_cast<const TimestampType&>(*datum.type()).timezone(); +} + +static inline const std::string& GetInputTimezone(const Scalar& scalar) { + return checked_cast<const TimestampType&>(*scalar.type).timezone(); +} + +static inline const std::string& GetInputTimezone(const ArrayData& array) { + return checked_cast<const TimestampType&>(*array.type).timezone(); +} + +template <typename T> +enable_if_timestamp<T, const std::string> GetInputTimezone(const DataType& type) { Review comment: Good point, fixed. I suppose it worked before since it was called as `GetInputTimezone<T>(...)`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
