nealrichardson commented on a change in pull request #11221:
URL: https://github.com/apache/arrow/pull/11221#discussion_r717552812
##########
File path: .github/workflows/r.yml
##########
@@ -211,30 +204,140 @@ jobs:
uses: actions/cache@v2
with:
path: ccache
- key: r-${{ matrix.rtools }}-ccache-mingw-${{ hashFiles('cpp/**') }}
- restore-keys: r-${{ matrix.rtools }}-ccache-mingw-
+ key: r-${{ matrix.config.rtools }}-ccache-mingw-${{
hashFiles('cpp/**') }}
+ restore-keys: r-${{ matrix.config.rtools }}-ccache-mingw-
# We use the makepkg-mingw setup that is included in rtools40 even when
# we use the rtools35 compilers, so we always install R 4.0/Rtools40
- uses: r-lib/actions/setup-r@master
with:
- rtools-version: 40
r-version: "4.1"
+ rtools-version: 40
Ncpus: 2
- uses: r-lib/actions/setup-r@master
- if: ${{ matrix.rtools == 35 }}
+ if: ${{ matrix.config.rtools == 35 }}
with:
rtools-version: 35
r-version: "3.6"
Ncpus: 2
- name: Build Arrow C++
shell: bash
env:
- RTOOLS_VERSION: ${{ matrix.rtools }}
+ RTOOLS_VERSION: ${{ matrix.config.rtools }}
+ MINGW_ARCH: ${{ matrix.config.arch }}
run: ci/scripts/r_windows_build.sh
+ - name: Rename libarrow.zip
+ # So that they're unique when multiple are downloaded in the next step
+ shell: bash
+ run: mv libarrow.zip libarrow-rtools${{ matrix.config.rtools }}-${{
matrix.config.arch }}.zip
- uses: actions/upload-artifact@v1
with:
- name: Rtools ${{ matrix.rtools }} Arrow C++
- path: libarrow.zip
+ name: libarrow-rtools${{ matrix.config.rtools }}-${{
matrix.config.arch }}.zip
+ path: libarrow-rtools${{ matrix.config.rtools }}-${{
matrix.config.arch }}.zip
+ # We can remove this when we drop support for Rtools 3.5.
+ - name: Ensure using system tar in actions/cache
+ run: |
+ Write-Output "${Env:windir}\System32" | `
+ Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
+
+ windows-r:
+ needs: [windows-cpp]
+ name: AMD64 Windows R RTools ${{ matrix.rtools }}
+ runs-on: windows-latest
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 60
+ strategy:
+ fail-fast: false
+ matrix:
+ rtools: [35, 40]
+ env:
+ ARROW_R_CXXFLAGS: "-Werror"
+ _R_CHECK_TESTS_NLINES_: 0
+ steps:
+ - run: git config --global core.autocrlf false
+ - name: Checkout Arrow
+ uses: actions/checkout@v2
+ with:
+ fetch-depth: 0
+ - run: mkdir r/windows
+ - name: Download artifacts
Review comment:
/me stares harder
you are right, that is strange, will fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
