cpcloud commented on a change in pull request #11259:
URL: https://github.com/apache/arrow/pull/11259#discussion_r717762569
##########
File path: cpp/src/gandiva/precompiled/timestamp_arithmetic.cc
##########
@@ -17,6 +17,7 @@
#include "./epoch_time_point.h"
+static int days_in_a_month[] = {31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30,
31};
Review comment:
one option might be to have a 2 by 12 array where the first row is days
in months in non-leap years, and the second is days in months with leap years.
you can probably then avoid some of the repeated branching code below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
