bkietz commented on a change in pull request #11243:
URL: https://github.com/apache/arrow/pull/11243#discussion_r717858310
##########
File path: experimental/computeir/Relation.fbs
##########
@@ -120,10 +120,10 @@ table Join {
left: Relation (required);
/// Right relation
right: Relation (required);
- /// The expression which will be evaluated against rows from each
+ /// Conjunction of expressions that will be evaluated against rows from each
/// input to determine whether they should be included in the
/// join relation's output.
- on_expression: Expression (required);
+ predicates: [Expression] (required);
Review comment:
Perhaps unsurprisingly, I'd prefer to keep this minimal and not have a
list of expressions. Adding the list is an implicit extra way to specify an
`AND` which is redundancy I'd prefer to avoid. I'm not strongly against it,
however
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
