westonpace commented on a change in pull request #11243:
URL: https://github.com/apache/arrow/pull/11243#discussion_r717005921
##########
File path: experimental/computeir/Relation.fbs
##########
@@ -120,10 +120,10 @@ table Join {
left: Relation (required);
/// Right relation
right: Relation (required);
- /// The expression which will be evaluated against rows from each
+ /// Conjunction of expressions that will be evaluated against rows from each
/// input to determine whether they should be included in the
/// join relation's output.
- on_expression: Expression (required);
+ predicates: [Expression] (required);
Review comment:
This may be a foolish question but what do we gain from allowing a list
of expressions which are (presumably, if I understand) combined by an implicit
conjunction (AND? OR?)
Couldn't the conjunction just be supplied explicitly by the producer?
Wouldn't that be clearer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
