zeroshade commented on a change in pull request #11206: URL: https://github.com/apache/arrow/pull/11206#discussion_r718531178
########## File path: go/arrow/memory/internal/cgoalloc/allocator.cc ########## @@ -0,0 +1,75 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +// +build ccalloc + +#include "allocator.h" +#include "arrow/memory_pool.h" +#include "helpers.h" + +struct mem_holder { + std::unique_ptr<arrow::MemoryPool> pool; + arrow::MemoryPool* current_pool; Review comment: `arrow::default_memory_pool` returns a raw pointer, so if this is holding a reference to the *default* memory pool, `current_pool` can be set to the pointer without worry of deleting it. The `unique_ptr` is there for the case where we're not using the `default_memory_pool`, allowing the logic to not have to explicitly check which is in use when using the allocate/reallocate functions since the raw pointer should always be valid regardless of if it's using the default memory pool or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
