pitrou commented on a change in pull request #10955: URL: https://github.com/apache/arrow/pull/10955#discussion_r718824101
########## File path: cpp/src/arrow/testing/gtest_util.h ########## @@ -94,7 +94,7 @@ #define ARROW_EXPECT_OK(expr) \ do { \ - auto _res = (expr); \ + const auto& _res = (expr); \ Review comment: Perhaps @bkietz can advise on this. On a more abstract standpoint, I'm not sure applying IDE-driven suggestions is necessarily a good strategy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org