lidavidm commented on a change in pull request #11233:
URL: https://github.com/apache/arrow/pull/11233#discussion_r718819715
##########
File path: cpp/src/arrow/compute/kernels/scalar_string_test.cc
##########
@@ -724,7 +724,7 @@ TYPED_TEST(TestStringKernels, IsUpperAscii) {
"[false, null, false, true, true, false, false]");
}
-TYPED_TEST(TestStringKernels, MatchSubstring) {
+TYPED_TEST(TestBinaryKernels, MatchSubstring) {
Review comment:
I suspect the issue is that JSON requires inputs to be in UTF-8 or
another encoding of Unicode. See for instance RapidJSON's documentation (which
is what we use): https://rapidjson.org/md_doc_encoding.html
So for such tests, you may have to manually construct input data. (Or it
seems like the validation can be turned off in RapidJSON.) A helper that takes
a vector<std::string> and gives back an array might suffice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
