thisisnic commented on a change in pull request #11232:
URL: https://github.com/apache/arrow/pull/11232#discussion_r718384360
##########
File path: r/R/dplyr-functions.R
##########
@@ -330,6 +330,39 @@ arrow_string_join_function <- function(null_handling,
null_replacement = NULL) {
}
}
+# Currently, Arrow does not supports a locale option for string case conversion
+# functions, contrast to stringr's API, so the 'locale' argument is only valid
+# for stringr's default value ("en"). The following are string functions that
+# take a 'locale' option as its second argument:
+# str_to_lower
+# str_to_upper
+# str_to_title
+#
+# Arrow locale will be supported with ARROW-14126
+nse_funcs$str_to_lower <- function(string, locale = "en") {
+ if (!identical(locale, "en")) {
+ stop("Providing 'locale' to 'str_to_lower' is not supported in Arrow; ",
+ "to change locale use 'Sys.setlocale()'", call. = FALSE)
Review comment:
Small phrasing suggestion (would need copying to the others too).
```suggestion
stop("Providing a value for 'locale' other than the default ('en') is
not supported by Arrow. ",
"To change locale, use 'Sys.setlocale()'", call. = FALSE)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
