pitrou commented on a change in pull request #11211:
URL: https://github.com/apache/arrow/pull/11211#discussion_r718371309
##########
File path: cpp/src/gandiva/precompiled/CMakeLists.txt
##########
@@ -31,14 +31,13 @@ set(PRECOMPILED_SRCS
../../arrow/util/basic_decimal.cc)
if(MSVC)
- # clang pretends to be a particular version of MSVC. Version 1900 is
- # Visual Studio 2015, 191[0-9] is Visual Studio 2017, and the standard
- # library uses C++14 features, so we have to use that -std version to
- # get the IR compilation to work
+ # clang pretends to be a particular version of MSVC. 191[0-9] is
+ # Visual Studio 2017, and the standard library uses C++14 features,
+ # so we have to use that -std version to get the IR compilation to work
if(MSVC_VERSION MATCHES "^191[0-9]$")
Review comment:
As much as possible, yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
