jonkeane commented on a change in pull request #11277:
URL: https://github.com/apache/arrow/pull/11277#discussion_r719389864
##########
File path: r/R/metadata.R
##########
@@ -142,7 +142,8 @@ arrow_attributes <- function(x, only_top_level = FALSE) {
}
columns <- NULL
- if (is.list(x) && !inherits(x, "POSIXlt")) {
+ attempt_to_save_row_level <- getOption("arrow.preserve_row_level_metadata",
FALSE)
+ if (attempt_to_save_row_level && is.list(x) && !inherits(x, "POSIXlt")) {
# However, if we are inside of a dplyr collection (including all datasets),
# we cannot apply this row-level metadata, since the order of the rows is
# not guaranteed to be the same, so don't even try, but warn what's going
on
Review comment:
If we disable any writing of this data at all, yes we could. Though if
we retain the ability to write it with an option, we should still keep this
since datasets + row-level metadata simply does not work in any circumstance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
