zeroshade commented on a change in pull request #11206:
URL: https://github.com/apache/arrow/pull/11206#discussion_r719561452
##########
File path: .github/workflows/go.yml
##########
@@ -163,3 +197,91 @@ jobs:
- name: Test
shell: bash
run: ci/scripts/go_test.sh .
+
+ macos-cgo:
+ name: AMD64 MacOS 10.15 Go ${{ matrix.go }} - CGO
+ runs-on: macos-latest
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 60
+ strategy:
+ fail-fast: false
+ matrix:
+ go: [1.15]
+ env:
+ ARROW_GO_TESTCGO: "1"
+ steps:
+ - name: Install go
+ uses: actions/setup-go@v1
+ with:
+ go-version: ${{ matrix.go }}
+ - name: Checkout Arrow
+ uses: actions/checkout@v2
+ with:
+ fetch-depth: 0
+ - name: Fetch Submodules and Tags
+ shell: bash
+ run: ci/scripts/util_checkout.sh
+ - name: Brew Install Arrow
+ shell: bash
+ run: brew install apache-arrow
+ - name: Build
+ shell: bash
+ run: ci/scripts/go_build.sh .
+ - name: Test
+ shell: bash
+ run: ci/scripts/go_test.sh .
+
+ windows-mingw:
+ name: AMD64 Windows MinGW ${{ matrix.mingw-n-bits }} CGO
+ runs-on: windows-latest
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 60
+ strategy:
+ fail-fast: false
+ matrix:
+ go: [1.15]
+ mingw-n-bits:
+ #- 32 runtime handling for CGO needs 64-bit currently
+ - 64
+ env:
+ ARROW_GO_TESTCGO: "1"
+ steps:
+ - name: Disable Crash Dialogs
+ run: |
+ reg add `
+ "HKCU\SOFTWARE\Microsoft\Windows\Windows Error Reporting" `
+ /v DontShowUI `
+ /t REG_DWORD `
+ /d 1 `
+ /f
+ - name: Install go
+ uses: actions/setup-go@v1
+ with:
+ go-version: ${{ matrix.go }}
+ - name: Checkout Arrow
+ uses: actions/checkout@v2
+ with:
+ fetch-depth: 0
+ - name: Fetch Submodules and Tags
+ shell: bash
+ run: ci/scripts/util_checkout.sh
+ - uses: msys2/setup-msys2@v2
+ with:
+ msystem: MINGW${{ matrix.mingw-n-bits }}
+ update: true
+ - name: Setup MSYS2
+ shell: msys2 {0}
+ run: |
+ ci/scripts/msys2_setup.sh cgo
+ - name: Update CGO Env vars
+ shell: msys2 {0}
+ run: |
+ echo "CGO_CPPFLAGS=-I$(cygpath --windows ${MINGW_PREFIX}/include)"
>> $GITHUB_ENV
+ echo "CGO_LDFLAGS=-g -O2 -L$(cygpath --windows ${MINGW_PREFIX}/lib)
-L$(cygpath --windows ${MINGW_PREFIX}/bin)" >> $GITHUB_ENV
+ echo "$(cygpath --windows ${MINGW_PREFIX}/bin)" >> $GITHUB_PATH
Review comment:
Ok, confirmed that i need the `... >> $GITHUB_PATH` looks like
`${MINGW_PREFIX}/bin` is *not* included in the `shell: bash` context
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
