ianmcook commented on a change in pull request #11257:
URL: https://github.com/apache/arrow/pull/11257#discussion_r720333600
##########
File path: r/tests/testthat/test-dplyr-summarize.R
##########
@@ -227,6 +228,19 @@ test_that("Group by n_distinct() on dataset", {
collect(),
tbl
)
+ # Without groupby
+ expect_dplyr_equal(
+ input %>%
+ summarize(distinct = n_distinct(int, na.rm = FALSE)) %>%
Review comment:
If `count_distinct` works on Boolean input now, let's change these tests
back to using `lgl` to match the other tests directly above.
```suggestion
summarize(distinct = n_distinct(lgl, na.rm = FALSE)) %>%
```
##########
File path: r/tests/testthat/test-dplyr-summarize.R
##########
@@ -227,6 +228,19 @@ test_that("Group by n_distinct() on dataset", {
collect(),
tbl
)
+ # Without groupby
+ expect_dplyr_equal(
+ input %>%
+ summarize(distinct = n_distinct(int, na.rm = FALSE)) %>%
+ collect(),
+ tbl
+ )
+ expect_dplyr_equal(
+ input %>%
+ summarize(distinct = n_distinct(int, na.rm = TRUE)) %>%
Review comment:
```suggestion
summarize(distinct = n_distinct(lgl, na.rm = TRUE)) %>%
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
