matthewmturner commented on pull request #1063: URL: https://github.com/apache/arrow-datafusion/pull/1063#issuecomment-932345310
> It would be very reassuring if these optimizations came with a more systematic testing routine. I agree that unit tests in this precise scenario are not very powerful. Currently we have a test here: > > https://github.com/apache/arrow-datafusion/blob/558d8ecfe2d1b0737de1e2548c5fbedc0ea17ada/datafusion/tests/sql.rs#L3020 > > that ensures that the count optimizer rule kicks in properly with `EXPLAIN [ANALYZE]`. What do you think about creating a separate integration test file called `optimizers.rs` that runs SQL queries and checks if they were optimized as expected? I'm happy to do this. Do you think better to make that file on a separate PR or maybe i could just add it for these count optimizations for now and a separate PR for the other optimizations? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
