pjmore commented on a change in pull request #1066:
URL: https://github.com/apache/arrow-datafusion/pull/1066#discussion_r720552449
##########
File path: datafusion/src/physical_plan/functions.rs
##########
@@ -543,6 +553,28 @@ macro_rules! invoke_if_unicode_expressions_feature_flag {
};
}
+///Function volatility determines when a function can be inlined or in the
future have evaluations elided when the arguments are the same
+///Immutable - a pure function which always remains the same
+///Stable - Maybe not required?. Used for functions which can modify the db
but are stable for multiple calls in statement
+///Volatile - Functions where output can vary for each call.
+///For more information see
https://www.postgresql.org/docs/current/xfunc-volatility.html
+#[derive(Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)]
+#[repr(u32)]
Review comment:
No particular reason I just wanted to be able to filter on the
volatility being equal to or stricter than a given level and I wasn't sure how
the derived derived implementations would do it. I'll remove the representation
and switch to the default derived version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
