edponce commented on a change in pull request #11298:
URL: https://github.com/apache/arrow/pull/11298#discussion_r720712341
##########
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##########
@@ -4299,6 +4390,10 @@ void RegisterScalarStringAscii(FunctionRegistry*
registry) {
&utf8_ltrim_whitespace_doc);
MakeUnaryStringBatchKernel<UTF8RTrimWhitespace>("utf8_rtrim_whitespace",
registry,
&utf8_rtrim_whitespace_doc);
+ MakeUnaryStringBatchKernel<Utf8Nfd>("utf8_nfd", registry, &utf8_nfd_doc);
+ MakeUnaryStringBatchKernel<Utf8Nfkd>("utf8_nfkd", registry, &utf8_nfkd_doc);
+ MakeUnaryStringBatchKernel<Utf8Nfc>("utf8_nfc", registry, &utf8_nfc_doc);
+ MakeUnaryStringBatchKernel<Utf8Nfkc>("utf8_nfkc", registry, &utf8_nfkc_doc);
Review comment:
I am curious if we should have a single normalization kernel and have
`NormalizationFormOptions` be provided as a `FunctionOptions`. Also,
`NormalizationFormOptions` could be part of `FunctionOptions` for all the other
`utf8_xxx` compute functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
