JayjeetAtGithub commented on a change in pull request #10913: URL: https://github.com/apache/arrow/pull/10913#discussion_r720727019
########## File path: cpp/src/skyhook/client/file_skyhook.h ########## @@ -0,0 +1,100 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +#pragma once + +#include "arrow/api.h" +#include "arrow/dataset/file_parquet.h" +#include "arrow/dataset/scanner.h" +#include "arrow/dataset/type_fwd.h" +#include "arrow/dataset/visibility.h" + +namespace skyhook { + +/// \addtogroup dataset-file-formats +/// +/// @{ + +/// \struct RadosConnCtx +/// \brief A struct to hold the parameters required +/// for connecting to a RADOS cluster. +struct RadosConnCtx { + std::string ceph_config_path; + std::string ceph_data_pool; + std::string ceph_user_name; + std::string ceph_cluster_name; + std::string ceph_cls_name; + + RadosConnCtx(const std::string& ceph_config_path, const std::string& ceph_data_pool, + const std::string& ceph_user_name, const std::string& ceph_cluster_name, + const std::string& ceph_cls_name) + : ceph_config_path(ceph_config_path), + ceph_data_pool(ceph_data_pool), + ceph_user_name(ceph_user_name), + ceph_cluster_name(ceph_cluster_name), + ceph_cls_name(ceph_cls_name) {} +}; + +/// \class SkyhookFileFormat Review comment: I changed to inherit from `arrow::dataset::FileFormat`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
