thisisnic commented on a change in pull request #11257:
URL: https://github.com/apache/arrow/pull/11257#discussion_r721393187
##########
File path: r/src/compute.cpp
##########
@@ -208,7 +208,7 @@ std::shared_ptr<arrow::compute::FunctionOptions>
make_compute_options(
return out;
}
- if (func_name == "hash_count_distinct") {
+ if (func_name == "count_distinct" || func_name == "hash_count_distinct") {
Review comment:
I'm not sure that would work in all cases, as there are a lot of
functions mapped to options classes where there is more going on than just a
straightforward mapping, but my understanding of the C++ and how it'd work
isn't enough to say for sure, so I'll leave it for others to comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
