emkornfield commented on a change in pull request #11302:
URL: https://github.com/apache/arrow/pull/11302#discussion_r721543618
##########
File path: python/pyarrow/lib.pyx
##########
@@ -37,6 +37,10 @@ arrow_init_numpy()
# (used from some of our C++ code, see e.g. ARROW-5260)
import_pyarrow()
+cdef libarrow.ArrowToPython ARROW_TO_PYTHON
Review comment:
yes, globally defined converter. This will likely change based on the
outcome of simplying "as_py" but before it required getting references to
Pandas types. In the long run we likely need to import a few others
(timestamp, timedelta, decimal, etc). It seems like for Pandas we used C++
static variables. It felt cleaner to me make it an explicit object. Again
don't feel too strongly here and if we eliminate the immediate need to share
Pandas conversion logic this could go away. Do you have a preference on the
pattern here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
