jhorstmann commented on pull request #810: URL: https://github.com/apache/arrow-rs/pull/810#issuecomment-933695586
The C++ validation looks extensive and includes offsets and dictionary keys, so basing the logic on that makes sense. These offsets and dictionary keys are actually my main performance concern, I think we want at least an `ArrayData::new_unchecked` for usage in `Array::slice` and `ArrayData::slice`. If the original offsets or keys were valid, then the slice can be assumed to also be valid. I'd also like this unsafe method to be public for anyone wanting to implement kernels outside of arrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
