kou commented on a change in pull request #10913:
URL: https://github.com/apache/arrow/pull/10913#discussion_r721811366
##########
File path: cpp/src/arrow/dataset/file_base.h
##########
@@ -165,7 +165,7 @@ class ARROW_DS_EXPORT FileFormat : public
std::enable_shared_from_this<FileForma
FileSource source, compute::Expression partition_expression,
std::shared_ptr<Schema> physical_schema);
- /// \brief Create a FileFragment for a FileSource.
+ /// \brief Create a FileFragment for a FileSource.x
Review comment:
```suggestion
/// \brief Create a FileFragment for a FileSource.
```
##########
File path: cpp/src/skyhook/CMakeLists.txt
##########
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitationsn
+# under the License.
+
+# add the client subdirectory
+add_subdirectory(client)
+
+# define the targets to build
+add_custom_target(arrow_skyhook_client)
+add_custom_target(cls_skyhook)
+
+# define the dependencies
+find_package(librados REQUIRED)
+include_directories(${LIBRADOS_INCLUDE_DIR})
+set(ARROW_SKYHOOK_LINK_STATIC arrow_dataset_static)
+set(ARROW_SKYHOOK_LINK_SHARED arrow_dataset_shared)
+set(ARROW_SKYHOOK_LINK_STATIC ${ARROW_SKYHOOK_LINK_STATIC} ${LIBRADOS_LIBRARY})
+set(ARROW_SKYHOOK_LINK_SHARED ${ARROW_SKYHOOK_LINK_SHARED} ${LIBRADOS_LIBRARY})
Review comment:
CMake uses `IMPORTED_LOCATION` and `INTERFACE_INCLUDE_DIRECTORIES`
properties of `librados::rados` automatically:
```suggestion
set(ARROW_SKYHOOK_LINK_STATIC arrow_dataset_static librados::rados)
set(ARROW_SKYHOOK_LINK_SHARED arrow_dataset_shared librados::rados)
```
##########
File path: dev/tasks/tasks.yml
##########
@@ -875,6 +875,15 @@ tasks:
image: ubuntu-cpp
{% endfor %}
+ test-skyhook-integration:
+ ci: github
+ template: docker-tests/github.linux.yml
+ params:
+ flags: -e ARROW_SKYHOOK=ON
+ env:
+ UBUNTU: 20.04
Review comment:
We're sorting this in alphabetical order.
```suggestion
env:
UBUNTU: 20.04
flags: -e ARROW_SKYHOOK=ON
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
