karldw opened a new pull request #11334:
URL: https://github.com/apache/arrow/pull/11334
Is this right? I passed these as `AR=` and `RANLIB=` instead of
`-DCMAKE_AR=` and `-DCMAKE_RANLIB=`. It seems like `BZIP2_EXTRA_ARGS` gets
passed straight to `make`.
I did:
```cmake
if(CMAKE_AR)
list(APPEND BZIP2_EXTRA_ARGS AR=${CMAKE_AR})
endif()
if(CMAKE_RANLIB)
list(APPEND BZIP2_EXTRA_ARGS RANLIB=${CMAKE_RANLIB})
endif()
```
Instead of:
https://github.com/apache/arrow/blob/bad8824d5cda0fd8337c7167729c49af868f93a5/cpp/cmake_modules/ThirdpartyToolchain.cmake#L636-L642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]