jorisvandenbossche commented on a change in pull request #11328:
URL: https://github.com/apache/arrow/pull/11328#discussion_r723038079
##########
File path: cpp/src/arrow/compute/kernels/scalar_cast_test.cc
##########
@@ -1547,8 +1547,56 @@ TEST(Cast, TimestampToString) {
CheckCast(
ArrayFromJSON(timestamp(TimeUnit::SECOND), "[-30610224000,
-5364662400]"),
ArrayFromJSON(string_type, R"(["1000-01-01 00:00:00", "1800-01-01
00:00:00"])"));
+
+ CheckCast(
+ ArrayFromJSON(timestamp(TimeUnit::SECOND, "UTC"), "[-30610224000,
-5364662400]"),
+ ArrayFromJSON(string_type, R"(["1000-01-01 00:00:00", "1800-01-01
00:00:00"])"));
Review comment:
Shouldn't we keep some indication of that it has a time zone (was an
instant) in the case of UTC as well? (otherwise a roundtrip to csv would give a
native timestamp without timezone for UTC, but a timestamp with timezone (UTC)
for non-UTC timezones)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
