emkornfield edited a comment on pull request #11302: URL: https://github.com/apache/arrow/pull/11302#issuecomment-936299002
@pitrou is changing the signature and docs to be specific to MonthDayNanoInterval in this module OK for this PR or do you have another suggestion on organization? Move it to datetime.h? On Wednesday, October 6, 2021, Antoine Pitrou ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In cpp/src/arrow/python/arrow_to_python.cc > <https://github.com/apache/arrow/pull/11302#discussion_r723139253>: > > > + } > + > + PyListAssigner& operator+=(int64_t offset) { > + current_index_ += offset; > + return *this; > + } > + > + private: > + PyObject* list_; > + int64_t current_index_ = 0; > +}; > + > +} // namespace > + > +Result<PyObject*> ArrowToPython::ToPyList(const Array& array) { > + RETURN_NOT_OK(CheckInterval(*array.type())); > > I see. I'd rather see a comprehensive refactor in another PR than a stub > like this, which may end up abandoned. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/arrow/pull/11302#discussion_r723139253>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AEIKYDWFIVHB3GUOHI2735TUFQV2RANCNFSM5FITG4GA> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
