alamb commented on a change in pull request #816:
URL: https://github.com/apache/arrow-rs/pull/816#discussion_r723348294
##########
File path: arrow/src/compute/kernels/cast.rs
##########
@@ -1680,12 +1680,8 @@ fn cast_list_inner<OffsetSize: OffsetSizeTrait>(
let array_data = ArrayData::new(
to_type.clone(),
array.len(),
- Some(cast_array.null_count()),
- cast_array
- .data()
- .null_bitmap()
- .clone()
- .map(|bitmap| bitmap.bits),
+ Some(data.null_count()),
Review comment:
This is also consistent with arrow2:
https://github.com/jorgecarleitao/arrow2/blob/a15044a1bc0c079c40520ad5e91b240998b3ee0a/src/compute/cast/mod.rs#L282
FWIW
##########
File path: arrow/src/compute/kernels/cast.rs
##########
@@ -1680,12 +1680,8 @@ fn cast_list_inner<OffsetSize: OffsetSizeTrait>(
let array_data = ArrayData::new(
to_type.clone(),
array.len(),
- Some(cast_array.null_count()),
- cast_array
- .data()
- .null_bitmap()
- .clone()
- .map(|bitmap| bitmap.bits),
+ Some(data.null_count()),
Review comment:
This is also consistent with arrow2:
https://github.com/jorgecarleitao/arrow2/blob/a15044a1bc0c079c40520ad5e91b240998b3ee0a/src/compute/cast/mod.rs#L282
cc @jorgecarleitao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
