emkornfield commented on pull request #11302: URL: https://github.com/apache/arrow/pull/11302#issuecomment-937291121
@jorisvandenbossche thanks for the feedback. Please see responses inline > Looks good! Added a few inline comments. And some additional non-inline comments: > > * Can you also add it to `test_types.py` (eg adding to `get_all_types()` will automatically run some tests) It looks like this has been refactored. Please let me know if I did it correctly. > > I can also push myself for those (trivial) changes if you want. > I think I've addressed all the feedback here, let me know if I've missed something. > One other question (but doesn't need to be handled here): > > * Should we allow creating an interval array from plain tuples instead of only from the MonthDayNano named tuple? Possibly, I think we can add this if users request it later. I don't think there is a need to do it here because tuples already get inferred as lists. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
