lidavidm commented on a change in pull request #11285:
URL: https://github.com/apache/arrow/pull/11285#discussion_r724130781
##########
File path: cpp/src/arrow/util/thread_pool.cc
##########
@@ -183,9 +183,10 @@ static void WorkerLoop(std::shared_ptr<ThreadPool::State>
state,
ARROW_UNUSED(std::move(task)); // release resources before waiting
for lock
lock.lock();
}
- if ARROW_PREDICT_FALSE(--state->tasks_queued_or_running_ == 0) {
- state->cv_idle_.notify_all();
- }
+ if
+ ARROW_PREDICT_FALSE(--state->tasks_queued_or_running_ == 0) {
Review comment:
Looks like a set of parentheses is missing here? (Seems like it works
because the macro definition has a set of parens, but usually this still gets
wrapped)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
